Add API docs for AzureAppServices and SignalR.Specification #28963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
commented
Dec 31, 2020
| public abstract class HubLifetimeManagerTestsBase<THub> where THub : Hub | ||
| { | ||
| public HubLifetimeManager<THub> Manager { get; set; } |
There was a problem hiding this comment.
Technically a breaking change, but no one uses this package so... 🤷
Also, it didn't do anything before.
There was a problem hiding this comment.
Let's keep this. We could consider Obsoleting it though.
pranavkm
approved these changes
Jan 3, 2021
| public abstract HubLifetimeManager<THub> CreateNewHubLifetimeManager(); | ||
|
|
||
| /// <summary> | ||
| /// Creates a couple connections, registers them with the lifetime manager, then checks that |
There was a problem hiding this comment.
~~couple~ --> few or couple of.
I'd also consider just describing this as
Specification test for SignalR HubLifetimeManager.
Seems overkill to describe what the test does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27538