Skip to content

Add API docs to twitter auth #29473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2021
Merged

Add API docs to twitter auth #29473

merged 3 commits into from
Jan 21, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jan 20, 2021

Part of #27538

@HaoK HaoK requested a review from Tratcher as a code owner January 20, 2021 21:12
@ghost ghost added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jan 20, 2021
Tratcher
Tratcher reviewed Jan 20, 2021
View reviewed changes
src/Security/Authentication/Twitter/src/TwitterHandler.cs
/// <summary>
/// Initializes a new instance of <see cref="TwitterHandler"/>.
/// </summary>
/// <inheritdoc />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <inheritdoc />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this copies the param docs, I copied this from the facebook handler ctor

@HaoK HaoK merged commit a2300a8 into master Jan 21, 2021
@HaoK HaoK deleted the haok/twitter branch January 21, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @Tratcher