Changed default server for samples from IIS Express to Kestrel #29517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyasJejurkar
requested review from
halter73,
javiercn,
jkotalik,
pranavkm and
Tratcher
as code owners
|
@MCCshreyas thanks for your contribution! It looks great, the only comment I have is that I believe there might be missing projects that need this treatment, for example the ones in Blazor. Ideally we want to tackle all the projects in the repo in one go. @Tratcher can you look at the ones in Server? |
javiercn
added
community-contribution
|
Sure @javiercn I will get those addressed in this PR only! |
ShreyasJejurkar
requested review from
BrennanConroy and
a team
as code owners
Tratcher
reviewed
Jan 22, 2021
src/DefaultBuilder/testassets/CreateDefaultBuilderApp/Properties/launchSettings.json
Show resolved
Hide resolved
src/Servers/IIS/IIS/test/IIS.Tests/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/samples/Http3SampleApp/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
src/Servers/testassets/ServerComparison.TestSites/Properties/launchSettings.json
Show resolved
Hide resolved
Removed IIS Settings from launchSettings and added launchSettings.json for HttpSys samples projects
ShreyasJejurkar
requested review from
Tratcher
and removed request for
a team
Tratcher
approved these changes
Jan 24, 2021
|
Thanks |
|
Hi @Tratcher. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping kestrel as the first option, VS will automatically show as the default option selected for debugging! (If not, make sure you delete the
.vsfolder from the root of the cloned repo. )I have kept some IIS servers test project
launchSettings.jsonuntouched because keeping IIS Express as the default option for them makes sense!Fixes #27630