Skip to content

[release/2.1] Update WixVersion #29880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

[release/2.1] Update WixVersion #29880

merged 1 commit into from
Feb 10, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 3, 2021

Update to a newer version of WiX that includes a signed wixstdba.dll. Should resolve #18091

@wtgodbe wtgodbe requested review from a team and joeloff February 3, 2021 19:05
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 3, 2021
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Feb 3, 2021
dougbu
dougbu approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, :shipit:

eng/targets/Wix.Common.props
<ProductVersion>3.11</ProductVersion>
<WixVersion>3.11.1</WixVersion>
<ProductVersion>3.14</ProductVersion>
<WixVersion>3.14.0-dotnet</WixVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @joeloff said in #18091,

we should give it a try

There's a very good chance this package will not change whether the wixstdba.dll file is signed. This package is an old fork and not that far removed from 3.11.1. Don't make this change if it leaves the file unsigned.

@wtgodbe wtgodbe merged commit 5ae1196 into release/2.1 Feb 10, 2021
@wtgodbe wtgodbe deleted the wtgodbe/21WixVer branch February 10, 2021 20:28
@github-actions github-actions bot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeloff joeloff Awaiting requested review from joeloff

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wtgodbe @dougbu