[release/2.1] Update Node dependencies for SignalR #30005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
area-signalr
|
I guess I need to update the patch.config as well |
BrennanConroy
force-pushed
the
brecon/21npm
branch
from
68c5853 to
d35565e
Compare
BrennanConroy
commented
Feb 10, 2021
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| /** @private */ | ||
| export function isArrayBuffer(val: any): val is ArrayBuffer { |
There was a problem hiding this comment.
Same code exists in 3.1, looks like updating the buffer version causes instanceof to not work anymore.
halter73
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customer Impact
This PR includes some routine updates to the Node packages that we reference in the SignalR library. Customers can apply these updates on their own but including them as part of the package reduces the friction for using the package.
Regression?
Risk
Minor version dependency updates.
Verification
Packaging changes reviewed?