Skip to content

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Mar 2, 2021

Instead of expecting a MetadataReference to resolve tag helpers from, we'll take an IAssemblySymbol because:

  • It plays nicer with the type that Rosyln exposes for the current compilation
  • Avoids us having to repeatedly convert a MetadataReference to an IAssemblySymbol in the tag helper providers

Also added a check for applicable tag helper providers to avoid looking for tag helpers in assemblies that are not the target assembly.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 2, 2021
@captainsafia captainsafia force-pushed the safia/rsg-asm-symbol branch from d53fb42 to e545ad2 Compare March 2, 2021 17:56
@captainsafia captainsafia force-pushed the safia/rsg-asm-symbol branch from e545ad2 to 1adcc74 Compare March 2, 2021 19:23
@captainsafia captainsafia marked this pull request as ready for review March 2, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants