Record har and video to helix upload dir #30637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-infrastructure
|
See https://dev.azure.com/dnceng/public/_build/results?buildId=1022985&view=ms.vss-test-web.build-test-results-tab&runId=31815646&resultId=125300&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab for what the har/videos look like in the helix test logs tab |
javiercn
approved these changes
Mar 4, 2021
|
Hello @HaoK! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dougbu
approved these changes
Mar 5, 2021
| _harPath = browserContextOptions.RecordHar.Path; | ||
| } | ||
|
|
||
| if (browserContextOptions?.RecordVideo?.Dir != null) | ||
| { | ||
| var uploadDir = Environment.GetEnvironmentVariable("HELIX_WORKITEM_UPLOAD_ROOT"); |
There was a problem hiding this comment.
nit: This could be done just once above line 55
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30135