-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Quarantining tests #30702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarantining tests #30702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#30672 already addresses the hosting issues.
@Tratcher is quarantining other tests though |
And now it's StartupConfigureServicesThrows_Fallback that is also in |
@JunTaoLuo so it's a side effect of the other test that you are disabled? I will remove this then, I understand what you meant now @Tratcher. |
I don't enough about how we quarantine tests, but in this instance the test was failing due to shared global state in the process. I assume after quarantining, the test now runs in a separate process, making it unlikely to ever fail while quarantined 😄 I'll file a work item to make our Activity tests more resilient by preferably moving them into a separate process. |
Hi @shirhatti. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Not quite. I think quarantined tests are skipped in normal runs but run normally in our special quarantine build. Quarantine is inadequate for tests that can cause side-effects for other tests. |
#30700
#30701