Remove per connection PipeOptions #30769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
- This changes the socket transport to remove the per connection allocation of PipeOptions.
davidfowl
force-pushed
the
davidfowl/singleton-pipe-options
branch
from
7cb3eb0 to
1c14fb6
Compare
Merged
Tratcher
approved these changes
Mar 9, 2021
JamesNK
reviewed
Mar 9, 2021
Comment on lines
+205
to
+210
| private class Settings | ||
| { | ||
| public PipeScheduler Scheduler { get; init; } = default!; | ||
| public PipeOptions InputOptions { get; init; } = default!; | ||
| public PipeOptions OutputOptions { get; init; } = default!; | ||
| } |
There was a problem hiding this comment.
nit: init + nullable is messy. Adding a ctor + readonly properties cleans things up
There was a problem hiding this comment.
nullable is messy. I don't want to reset the PR for this 😄 . I will look at it afterwards if that's OK
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes advantage of dotnet/runtime#49270
@BrennanConroy we should do something similar in SignalR