Skip to content

[Blazor] [Desktop] Exclude Resources.resx from the embedded file manifest #31107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 21, 2021
Merged

[Blazor] [Desktop] Exclude Resources.resx from the embedded file manifest #31107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Components/WebView/WebView/src/Microsoft.AspNetCore.Components.WebView.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Components.WebView.Test" />
</ItemGroup>

<ItemGroup>
<EmbeddedResource Update="Resources.resx" ExcludeFromManifest="true" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it be included at all to begin with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the embedded manifest file provider by default includes all embedded resources in it (don't ask me why we chose that default).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK that's definitely weird, but good to know!

</ItemGroup>

<ItemGroup>
<Compile Include="$(ComponentsSharedSourceRoot)src\WebEventData.cs" LinkBase="Shared" />
Expand Down