-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Fix file headers in src/SignalR #31433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could you also take a look at the Crankier folder? Looks like it got missed.
https://github.com/dotnet/aspnetcore/tree/main/src/SignalR/perf/benchmarkapps/Crankier
Thanks for your PR. Unfortunately, we can't take this PR as it's related to the licensing comments. These are things we're working on already so we'll have to close this. Thanks for your effort. |
Going to take a look why/how it was missed. This was literally a FixAll application from the command line. |
Hi @Youssef1313. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
@mkArtakMSFT Please see the discussion in #30132 |
Hi @Youssef1313. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
@BrennanConroy It was missed because it doesn't exist in |
Hi @Youssef1313. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Part of #18873