Fix flaky test ContentLength_Received_NoDataFrames_Reset #31787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
JamesNK
commented
Apr 14, 2021
Comment on lines
+517
to
+522
| // If the stream is complete after receiving the headers then run OnEndStreamReceived. | ||
| // If there is a bad content length then this will throw before the request delegate is called. | ||
| if (isCompleted) | ||
| { | ||
| await OnEndStreamReceived(); | ||
| } |
There was a problem hiding this comment.
This matches HTTP/2 behavior which validates content-length if end stream is received with HEADERS frame. Validation here prevents the RequestDelegate from executing if invalid.
jkotalik
approved these changes
Apr 15, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31777