Skip to content

HTTP/3: Add unit test for MaxRequestLineSize limit #31963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Apr 21, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 20, 2021

Addresses #29702

Adds unit test for HTTP/3 (and HTTP/2 because I couldn't find a test for it) Ok, there were unit tests. More don't hurt. The protocol error change in PR is still worth it.

@ghost ghost added the area-runtime label Apr 20, 2021
@JamesNK JamesNK force-pushed the jamesnk/http3-requestlinelength-tests branch from 6323971 to c20c3da Compare April 20, 2021 21:40
@JamesNK JamesNK added this to the 6.0-preview5 milestone Apr 20, 2021
@ghost
Copy link

ghost commented Apr 20, 2021

Hello @JamesNK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5c07d27 into main Apr 21, 2021
@ghost ghost deleted the jamesnk/http3-requestlinelength-tests branch April 21, 2021 03:12
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants