Skip to content

New E2E Migration (PW) test project #31990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 1, 2021
Merged

New E2E Migration (PW) test project #31990

merged 17 commits into from
May 1, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Apr 20, 2021

  • Get tests running on playwright/helix

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Apr 20, 2021
@HaoK HaoK force-pushed the haok/e2m branch 2 times, most recently from 440f7eb to fe3fdc3 Compare April 23, 2021 05:17
@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

This seems like a good initial checkpoint

Currently the single test in the project just verifies that it can go to the page with playwright, without verifying any functionality.

So this checkpoint has:

  • New Microsoft.AspNetCore.Components.Migrations.E2ETest project
  • Uses playwright on linux/osx/windows helix queues

Next iteration will focus on:

  • refactoring files to share between Blazor templates
  • adding some more real tests that actually do something

@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

FYI @captainsafia the razor error does seem to happen on CI, this is it right? I won't trigger a new build until you get a chance to confirm that this is indeed the same issue

src\Components\test\testassets\BasicTestApp\BindCasesComponent.razor(22,1131): error RZ9991: (NETCORE_ENGINEERING_TELEMETRY=Build) The attribute names could not be inferred from bind attribute 'bind-value'. Bind attributes should be of the form 'bind' or 'bind-value' along with their corresponding optional parameters like 'bind-value:event', 'bind:format' etc.

@captainsafia
Copy link
Member

Yes! This is the same issue as described in #31023.

This is the first time I'm seeing it happen in CI which is super spooky. Is it possible that a change to configuration made here made this issue appear where it previously didn't? Did it show up in a particular commit?

@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

Honestly I'm pretty sure I've seen this before on ci in my runs, I usually just restart it in the past

@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

I have a built in tolerance/expectation that the build fails frequently for things unrelated to my changes, so I'm trained to just kick the build a few times until it starts up... kind of like a lawn mower, needs a few good yanks to start...which is prob not ideal, but it is what it is :)

@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

One bit of info for you, it did happen after I configured helix-matrix to run, so perhaps that caused it to have bad cache data... since now two jobs are doing a built, idk what gets reused on the build machines between jobs or what not between yml...if anything, perhaps its just bad luck... but that's the only change I made, I wanted to run the full helix matrix as part of this PR to make sure the new test project doesn't explode on the other helix queues

@captainsafia
Copy link
Member

@HaoK Yeah I see the issue no longer repros after 963373c. It might very well have something to do with cache state on the machine.

@HaoK HaoK requested a review from javiercn April 28, 2021 18:53
@HaoK HaoK marked this pull request as ready for review April 28, 2021 18:53
@HaoK HaoK requested review from a team as code owners April 28, 2021 18:53
@HaoK
Copy link
Member Author

HaoK commented Apr 28, 2021

@javiercn I think its worth getting this in with no real tests as a starting point, so reliability shouldn't be an issue

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with the approach of getting this in to validate.

Left some questions inline.

//Assert.Equal("", _testOutcome.Text);
}

private void IssueRequest()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to leave the existing test code there since it might aid in the process of migrating this test to playwright apis later. All the commended out code is the selenium test code.

@HaoK HaoK merged commit ee11b07 into main May 1, 2021
@HaoK HaoK deleted the haok/e2m branch May 1, 2021 04:34
@ghost ghost added this to the 6.0-preview5 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants