-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New E2E Migration (PW) test project #31990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HaoK
commented
Apr 20, 2021
•
edited
Loading
edited
- Get tests running on playwright/helix
440f7eb
to
fe3fdc3
Compare
This seems like a good initial checkpoint Currently the single test in the project just verifies that it can go to the page with playwright, without verifying any functionality. So this checkpoint has:
Next iteration will focus on:
|
FYI @captainsafia the razor error does seem to happen on CI, this is it right? I won't trigger a new build until you get a chance to confirm that this is indeed the same issue
|
Yes! This is the same issue as described in #31023. This is the first time I'm seeing it happen in CI which is super spooky. Is it possible that a change to configuration made here made this issue appear where it previously didn't? Did it show up in a particular commit? |
Honestly I'm pretty sure I've seen this before on ci in my runs, I usually just restart it in the past |
I have a built in tolerance/expectation that the build fails frequently for things unrelated to my changes, so I'm trained to just kick the build a few times until it starts up... kind of like a lawn mower, needs a few good yanks to start...which is prob not ideal, but it is what it is :) |
One bit of info for you, it did happen after I configured helix-matrix to run, so perhaps that caused it to have bad cache data... since now two jobs are doing a built, idk what gets reused on the build machines between jobs or what not between yml...if anything, perhaps its just bad luck... but that's the only change I made, I wanted to run the full helix matrix as part of this PR to make sure the new test project doesn't explode on the other helix queues |
@javiercn I think its worth getting this in with no real tests as a starting point, so reliability shouldn't be an issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues with the approach of getting this in to validate.
Left some questions inline.
src/Components/test/testassets/TestServer/Components.TestServer.csproj
Outdated
Show resolved
Hide resolved
//Assert.Equal("", _testOutcome.Text); | ||
} | ||
|
||
private void IssueRequest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to leave the existing test code there since it might aid in the process of migrating this test to playwright apis later. All the commended out code is the selenium test code.