HTTP/3: Request and response data rates #32127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
JamesNK
changed the title
JamesNK
commented
Apr 24, 2021
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3TimeoutTests.cs
Show resolved
Hide resolved
halter73
reviewed
Apr 26, 2021
| case TimeoutReason.WriteDataRate: | ||
| Log.ResponseMinimumDataRateNotSatisfied(_context.ConnectionId, traceIdentifier: null); | ||
| Abort(new ConnectionAbortedException(CoreStrings.ConnectionTimedBecauseResponseMininumDataRateNotSatisfied), Http3ErrorCode.InternalError); | ||
| break; |
There was a problem hiding this comment.
This seems about the same as HttpConnection.OnTimeout(). Do you think it's worth changing Http3ConnectionMiddleware to call through HttpConnection like HttpConnectionMiddleware does?
Then we could make Http3Connection an IRequestProcessor like Http1Connection and Http2Connection giving us greater consistency. HttpConnection itself is pretty small, so I think it be a fairly small change.
There was a problem hiding this comment.
Discussed offline. Will attempt in a follow-up PR.
halter73
reviewed
Apr 26, 2021
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3TimeoutTests.cs
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/requestbodytimeout
branch
from
6b4e4f9 to
9ea3093
Compare
halter73
approved these changes
Apr 27, 2021
jkotalik
reviewed
Apr 27, 2021
jkotalik
approved these changes
Apr 27, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #29702