SkipLocalsInit on methods with stackalloc #32567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
changed the title
gfoidl
reviewed
May 11, 2021
| @@ -27,6 +28,7 @@ public DfaMatcher(ILogger<DfaMatcher> logger, EndpointSelector selector, DfaStat | |||
| _isDefaultEndpointSelector = selector is DefaultEndpointSelector; | |||
| } | |||
|
|
|||
| [SkipLocalsInit] | |||
There was a problem hiding this comment.
FWIW, you'll get better performance if you change line 48 to use a const value rather than a variable value. If it's impractical to do so, no change needed.
There was a problem hiding this comment.
Yeah, I noticed that. I don't want to mess with it in this PR: #32569 😄
halter73
approved these changes
May 12, 2021
|
Hello @JamesNK! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
amcasey
added
area-networking
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #26598 but explicitly adds the attribute on only some methods. The benefit is smaller but less likely to cause bugs.