Skip to content

Updated build.sh #32665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
May 14, 2021
Merged

Updated build.sh #32665

1 commit merged into from
May 14, 2021

Conversation

ShreyasJejurkar
Copy link
Contributor

Corrected explanation of option parameter.

@ShreyasJejurkar
Updated build.sh
d5fd9ae 
Corrected explanation of option parameter.
@ShreyasJejurkar ShreyasJejurkar requested a review from a team as a code owner May 14, 2021 06:05
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member labels May 14, 2021
dougbu
dougbu approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @ShreyasJejurkar❕

@ghost
Copy link

ghost commented May 14, 2021

Hello @dougbu!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 57 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ShreyasJejurkar
Copy link
Contributor Author

@dougbu haha. Just found this, while I was trying to build aspnetcore repo on codespaces.
Checking building on codespaces works or not!

@ShreyasJejurkar
Copy link
Contributor Author

Can we stop CI build forcefully, as these changes are outside of code and do not affect anything much!
So that we can save our resources a little bit!!

@dougbu
Copy link
Contributor

dougbu commented May 14, 2021

Can we stop CI build forcefully, as these changes are outside of code and do not affect anything much!
So that we can save our resources a little bit!!

Might be nice but causes problems w/ our branch protection rules. Admin overrides (which I could have used) are slightly safer and doc-only changes in this repo are uncommon…

One build when nobody's in a rush isn't a big deal😀

@ShreyasJejurkar
Copy link
Contributor Author

In some repos, I have seen filters for directories and files, so if there are changes in those particular files, CI won't run for those!

@dougbu
Copy link
Contributor

dougbu commented May 14, 2021

In some repos, I have seen filters for directories and files, so if there are changes in those particular files, CI won't run for those!

Yup. We tried that out then reverted it due to the branch protection rules we have in place and how that interacted w/ the YAML exclusions.

@ShreyasJejurkar
Copy link
Contributor Author

Ohh ok ok. Thanks for the clarification. 😀@dougbu

@ghost ghost merged commit 90b9d80 into dotnet:main May 14, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShreyasJejurkar @dougbu