Skip to content

[main] Update dependencies from dotnet/runtime dotnet/emsdk dotnet/efcore #32763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2021
Merged

[main] Update dependencies from dotnet/runtime dotnet/emsdk dotnet/efcore #32763

merged 4 commits into from
May 17, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 17, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20210517.1
  • Date Produced: 5/17/2021 10:12 AM
  • Commit: f64f12aa83d9f2253eab10551b716d2ba09371d2
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: 96159334-0390-4e49-6777-08d8f479343c
  • Build: 20210517.1
  • Date Produced: 5/17/2021 12:37 PM
  • Commit: 64eb11deae8391570a7b74f672e8f2ccdee0e7bd
  • Branch: refs/heads/main

From https://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 20210517.2
  • Date Produced: 5/17/2021 5:25 PM
  • Commit: 2b86d9f41f772ebd223e61d99e746bf8fb2853c5
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
6e62df0 
…0517.1

Microsoft.Win32.Registry , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.AspNetCore.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Ini , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.IO.Pipelines , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols
 From Version 6.0.0-preview.5.21265.5 -> To Version 6.0.0-preview.5.21267.1
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner May 17, 2021 12:07
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels May 17, 2021
ghost
ghost approved these changes May 17, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost ghost added the tell-mode Indicates a PR which is being merged during tell-mode label May 17, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202105…
57294b1 
…17.1

Microsoft.NET.Runtime.Emscripten.2.0.12.Node.win-x64 , Microsoft.NET.Runtime.Emscripten.2.0.12.Python.win-x64 , Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.win-x64
 From Version 6.0.0-preview.5.21262.1 -> To Version 6.0.0-preview.5.21267.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/emsdk May 17, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
8e09007 
…517.1

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 6.0.0-preview.5.21264.1 -> To Version 6.0.0-preview.5.21267.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/emsdk [main] Update dependencies from dotnet/runtime dotnet/emsdk dotnet/efcore May 17, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
9d122ca 
…517.2

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 6.0.0-preview.5.21264.1 -> To Version 6.0.0-preview.5.21267.2
@pranavkm
Copy link
Contributor

@HaoK I think the build failure is because both the E2ETests and E2EPWTests are running concurrently:

.dotnet/sdk/6.0.100-preview.5.21264.3/Sdks/Microsoft.NET.Sdk.BlazorWebAssembly/targets/Microsoft.NET.Sdk.BlazorWebAssembly.Current.targets(637,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) The process cannot access the file '/Users/runner/work/1/s/artifacts/obj/BasicTestApp/Release/net6.0/compress/7dXpmazM.gz' because it is being used by another process.

Did you already have the adding a fake project reference between the two tests in the works?

@HaoK
Copy link
Member

HaoK commented May 17, 2021

I do in my PR, but I can open one with just that change in main #32428

@pranavkm
Copy link
Contributor

That'd be great. I'll re-run it, but I suspect more builds will run in to since it's a random race condition.

@HaoK HaoK mentioned this pull request May 17, 2021
Merged
@HaoK
Copy link
Member

HaoK commented May 17, 2021

Cool opened #32787

@dotnet-maestro dotnet-maestro bot merged commit 3625803 into main May 17, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-8b7f3dcd-8838-487a-b11a-daf8c3e10917 branch May 17, 2021 20:59
@ghost ghost added this to the 6.0-preview5 milestone May 17, 2021
@dougbu
Copy link
Contributor

dougbu commented May 18, 2021

I suspect more builds will run in to since it's a random race condition.

@rainersigwald what's the best way to uncover potential build ordering issues❔

I checked out the commit before #32787 went in, cleaned the repo, and built the repo using our -all (fairly comprehensive) option. Unfortunately, I don't see artifacts/obj/BasicTestApp/Release/net6.0/compress/7dXpmazM.gz listed in the DoubleWrites section of the binary log. I was hoping that section would help us here.

image

@HaoK
Copy link
Member

HaoK commented May 18, 2021 •
edited
Loading

fyi @dougbu I also see this from time to time, but this might be due to me adding more potential build ordering issues with my PR #32428

.dotnet\sdk\6.0.100-preview.5.21264.3\Sdks\Microsoft.NET.Sdk.BlazorWebAssembly\targets\Microsoft.NET.Sdk.BlazorWebAssembly.Current.targets(543,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "GenerateBlazorWebAssemblyBootJson" task failed unexpectedly.
System.IO.IOException: The process cannot access the file 'D:\workspace\_work\1\s\artifacts\obj\BasicTestApp\Release\net6.0\blazor.publish.boot.json' because it is being used by another process.
   at System.IO.Strategies.FileStreamHelpers.ValidateFileHandle(SafeFileHandle fileHandle, String path, Boolean useAsyncIO) in System.Private.CoreLib.dll:token 0x6005b6c+0x25
   at System.IO.Strategies.FileStreamHelpers.CreateFileOpenHandle(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options) in System.Private.CoreLib.dll:token 0x6005b67+0x78
   at System.IO.Strategies.WindowsFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options) in System.Private.CoreLib.dll:token 0x6005c26+0x61
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) in System.Private.CoreLib.dll:token 0x6005b64+0x2c
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) in System.Private.CoreLib.dll:token 0x600583e+0xa8
   at System.IO.File.Create(String path) in System.IO.FileSystem.dll:token 0x60000f0+0x0
   at Microsoft.NET.Sdk.BlazorWebAssembly.GenerateBlazorWebAssemblyBootJson.Execute() in Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.dll:token 0x6000062+0x0
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() in Microsoft.Build.dll:token 0x60015da+0x3e
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) in Microsoft.Build.dll:token 0x600145a+0x809

@rainersigwald
Copy link
Member

@dougbu have you tried https://github.com/rainersigwald/ParallelBuildDebuggingLogger at all? It's . . . underdocumented 😬 but I find it helpful for this sort of investigation. If you can share the binlog with me (offline/internally is fine) I can take a quick look.

@ghost
Copy link

ghost commented May 18, 2021

Hi @rainersigwald. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Dependency Update 🔼
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @HaoK @dougbu @rainersigwald