Skip to content

Conversation

ShreyasJejurkar
Copy link
Contributor

@ShreyasJejurkar ShreyasJejurkar commented May 19, 2021

  1. Found the .NET foundation badge at https://img.shields.io/badge/.NET%20Foundation-blueviolet.svg
  2. Add to badge collection.

1. Found the .NET foundation badge at https://img.shields.io/badge/.NET%20Foundation-blueviolet.svg
2. Added to badge collection.
@ShreyasJejurkar ShreyasJejurkar requested a review from Pilchie as a code owner May 19, 2021 15:09
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 19, 2021
@ShreyasJejurkar ShreyasJejurkar changed the title chore (Badge) : Added .NET foundation badge chore (Badge) : Add .NET foundation badge May 19, 2021
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 19, 2021
@Pilchie Pilchie self-assigned this May 19, 2021
@Pilchie
Copy link
Member

Pilchie commented May 19, 2021

@terrajobst - is this a thing other repos are doing?

@ShreyasJejurkar
Copy link
Contributor Author

I have not seen this badge to other repo. But recently I cam across the new dotnet foundation project (https://github.com/reaqtive/reaqtor). And I saw that badge there!

@Pilchie
Copy link
Member

Pilchie commented May 20, 2021

@dotnet/aspdoi @dotnet/aspnet-build Any objections here? The site claims no tracking which was my only concern.

@dougbu
Copy link
Contributor

dougbu commented May 20, 2021

Any objections here?

I can't see anything objectionable and we use https://shields.io/ badges already in the Readme file. We have the horizontal room for another badge, it looks pretty good, and the link is helpful (despite the license text at the top of most files).

Minor but how helpful is it is to add the badge w/o a dynamic label providing additional information❔ I can't think of a constraint we need to weigh against this but thought I'd ask.

@Pilchie Pilchie merged commit e68043b into dotnet:main May 20, 2021
@ghost ghost added this to the 6.0-preview6 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants