-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/6.0-preview5] Fix WebApplication to read environment specific logging configuration #32926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
Taking tell mode off of this. At this point we should email tactics for approval on why this is crucial for Preview 5. |
- Add empty InMemoryCollection for storage by default
@Pilchie As much as I want the logging fix, this turned into a lot. I discussed with @davidfowl and we think it's okay to wait for preview6 for this so I'll retarget to main. |
Before this change, logging configuration like the following would not be respected if it was in an environment-specific config like
appsettings.Development.json
(as opposed toappsettings.json
).This also removes a ton of duplicate and conflicting configuration sources as noted previous closed PR: #32822
Loading less sources and not automatically reloading sources every time one is added during the "bootstrapping" of the default configuration results in far fewer file system checks leading to better startup performance.
Fixes #32383
Fixes #32432
@Pilchie