Skip to content

[release/6.0-preview5] Fix WebApplication to read environment specific logging configuration #32926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

halter73
Copy link
Member

Before this change, logging configuration like the following would not be respected if it was in an environment-specific config like appsettings.Development.json (as opposed to appsettings.json).

{
  "Logging": {
    "LogLevel": {
      "Default": "Information",
      "Microsoft": "Debug",
      "Microsoft.Hosting.Lifetime": "Information"
    }
  }
}

This also removes a ton of duplicate and conflicting configuration sources as noted previous closed PR: #32822

Loading less sources and not automatically reloading sources every time one is added during the "bootstrapping" of the default configuration results in far fewer file system checks leading to better startup performance.

Fixes #32383
Fixes #32432

@Pilchie

@halter73 halter73 added area-runtime api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews tell-mode Indicates a PR which is being merged during tell-mode labels May 21, 2021
@ghost
Copy link

ghost commented May 21, 2021

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

  • The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
  • The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
  • Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

@halter73 halter73 changed the title [release/6.0-preview5]] Fix WebApplication to read environment specific logging configuration [release/6.0-preview5] Fix WebApplication to read environment specific logging configuration May 21, 2021
@halter73 halter73 removed the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label May 21, 2021
@Pilchie
Copy link
Member

Pilchie commented May 25, 2021

Taking tell mode off of this. At this point we should email tactics for approval on why this is crucial for Preview 5.

@Pilchie Pilchie removed the tell-mode Indicates a PR which is being merged during tell-mode label May 25, 2021
@halter73
Copy link
Member Author

@Pilchie As much as I want the logging fix, this turned into a lot. I discussed with @davidfowl and we think it's okay to wait for preview6 for this so I'll retarget to main.

@halter73 halter73 closed this May 27, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants