Further reduce string allocations #32929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
pranavkm
force-pushed
the
prkrishn/more-allocations
branch
from
3813368 to
2232536
Compare
pranavkm
commented
May 22, 2021
src/Razor/Microsoft.AspNetCore.Razor.Language/src/RazorCodeDocumentExtensions.cs
Show resolved
Hide resolved
pranavkm
commented
May 22, 2021
...crosoft.AspNetCore.Mvc.Razor.Extensions/src/Microsoft.AspNetCore.Mvc.Razor.Extensions.csproj
Show resolved
Hide resolved
pranavkm
commented
May 22, 2021
| { | ||
| @namespace = null; | ||
| return false; | ||
| } | ||
|
|
||
| relativePath = NormalizePath(relativePath); |
There was a problem hiding this comment.
NormalizePath turned \\ to /. But turns out we were later splitting on either path separators so we can safely remove it.
src/Razor/Microsoft.AspNetCore.Razor.Language/src/Legacy/SourceLocationTracker.cs
Outdated
Show resolved
Hide resolved
| { | ||
| @namespace = null; | ||
| return false; | ||
| } | ||
|
|
||
| relativePath = NormalizePath(relativePath); |
There was a problem hiding this comment.
I mentioned this earlier, there's a Split that happens later on that tokenizes on either path separator and we only ever look at the path segments. The normalization is kinda moot.
JamesNK
reviewed
May 23, 2021
src/Razor/Microsoft.AspNetCore.Razor.Language/src/Extensions/DefaultTagHelperTargetExtension.cs
Outdated
Show resolved
Hide resolved
| @@ -568,6 +568,60 @@ public void IndexOf_SearchOnlyInsideTheRange_IfStartAndCountAreProvided() | |||
| Assert.Equal(-1, result); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
Nit: let's add a note in StringSegment.cs to explain why we're rolling out our own implementation.
There was a problem hiding this comment.
Added a doc comment to the type.
pranavkm
force-pushed
the
prkrishn/more-allocations
branch
3 times, most recently
from
b8b246b to
af9673d
Compare
pranavkm
force-pushed
the
prkrishn/more-allocations
branch
from
a669f97 to
f93643b
Compare
|
This has been updated. |
JamesNK
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bunch of places that performed Substring and Split and replaced them with StringSegment. Didn't make a dent in the micro-benchmark but this feels like a low cost fix to consider.