Skip to content

Added instructions to the documentation for forking the main repo. #33098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2021
Merged

Added instructions to the documentation for forking the main repo. #33098

merged 4 commits into from
Jun 4, 2021

Conversation

jacobslusser
Copy link
Contributor

Added instructions to the "build from source" documentation for forking the main dotnet/aspnet repo on GitHub. This way, engineers are set up to start creating PRs if they want to.

Addresses #28192

CC: @captainsafia

@jacobslusser jacobslusser requested a review from Pilchie as a code owner May 28, 2021 00:35
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 28, 2021
@dnfadmin
Copy link

dnfadmin commented May 28, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 28, 2021
@Pilchie
Copy link
Member

Pilchie commented May 28, 2021

Maybe a link to https://guides.github.com/activities/forking/ would be useful here?

@Pilchie Pilchie requested a review from captainsafia May 28, 2021 16:24
@jacobslusser
Copy link
Contributor Author

In lieu of the new instructions or as supplement to them?

@Pilchie
Copy link
Member

Pilchie commented May 28, 2021

I was thinking as a supplement.

captainsafia
captainsafia reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Added one other note about adding a reference to GitHub's new feature for keeping forks in sync as a non-CLI alternative.

@captainsafia captainsafia enabled auto-merge (squash) June 4, 2021 04:23
@captainsafia captainsafia merged commit 5fae4d6 into dotnet:main Jun 4, 2021
@ghost ghost added this to the 6.0-preview6 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captainsafia captainsafia captainsafia approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

@captainsafia captainsafia

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@jacobslusser @dnfadmin @Pilchie @captainsafia