Skip to content

Harmonize HttpClient creation in SpaProxyLaunchManager #33164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2021
Merged

Harmonize HttpClient creation in SpaProxyLaunchManager #33164

merged 2 commits into from
Jun 4, 2021
+16 −15

Conversation

johanndev
Copy link
Contributor

Adresses #33115

@johanndev
Fixes 33115
e7c8b60 
- Addition to dotnet#33135 - the ACCEPT Header was previously only set  during the `StartInBackground` method, but was missing from the `IsSpaProxyRunning` method.
- Extract HttpClient creation into method to ensure that the HttpClient used for probing the frontend development server is instantiated with consistent settings.
@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels May 31, 2021
@dnfadmin
Copy link

dnfadmin commented May 31, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@johanndev johanndev mentioned this pull request May 31, 2021
Closed
@johanndev johanndev changed the title Harmonize HttpClient creation SpaProxyLaunchManager Harmonize HttpClient creation in SpaProxyLaunchManager May 31, 2021
javiercn
javiercn reviewed Jun 1, 2021
View reviewed changes
javiercn
javiercn reviewed Jun 1, 2021
View reviewed changes
javiercn
javiercn reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added a couple of suggestions just to stay on the safer side. Otherwise, its good to go.

@johanndev
- Clarify comment about regarding accept header value
f46f16a 
- Add low quality factor to 'Any MIME type' accept header
@johanndev
Copy link
Contributor Author

@javiercn Thanks for your review! Is there any further action required from my side?

javiercn
javiercn approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@javiercn javiercn merged commit 180b4ad into dotnet:main Jun 4, 2021
@ghost ghost added this to the 6.0-preview6 milestone Jun 4, 2021
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@javiercn javiercn

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0-preview6

Development

Successfully merging this pull request may close these issues.

4 participants

@johanndev @dnfadmin @javiercn @amcasey