Try caching playwright browsers download #33557

HaoK · 2021-06-15T17:21:59Z

No description provided.

HaoK · 2021-06-15T22:51:55Z

/azp run

azure-pipelines · 2021-06-15T22:52:13Z

Azure Pipelines successfully started running 2 pipeline(s).

HaoK · 2021-07-15T16:25:13Z

/azp-run

HaoK · 2021-07-15T16:25:22Z

/azp run

azure-pipelines · 2021-07-15T16:25:41Z

Azure Pipelines successfully started running 2 pipeline(s).

HaoK · 2021-07-15T17:07:45Z

@dotnet/aspnet-build does anyone know why only this PR seems to fail with this error? I added some azure magic to try and cache our playwright browsers, but it shouldn't affect the mac os test leg at all... I've tried like 4-5+ times now

Error: Failed find: ENOENT: no such file or directory, lstat '/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebKitLegacy.framework/Versions/Versions'

wtgodbe · 2021-07-16T16:12:32Z

Very weird, I'm not sure. Could be an AzDO issue w/ the PublishTestResults task, maybe @riarenas knows?

riarenas · 2021-07-16T16:23:32Z

I haven't seen any ongoing issues with the publish test results task, so at the very least it's not a known issue. I would give it another try, and if it's consistently failing, we can raise an ICM.

@dotnet/dnceng for visibility.

MattGal · 2021-07-16T16:35:03Z

If you scroll up to the "run build.sh" stage there's lots of restore failures (new variant, same problem) in that stage. It's possible this incomplete restore has some impact?

  Determining projects to restore...
  Retrying 'FindPackagesByIdAsync' for source 'https://pkgs.dev.azure.com/azure-public/3ccf6661-f8ce-4e8a-bb2e-eff943ddd3c7/_packaging/58ca65bb-e6c1-4210-88ac-fa55c1cd7877/nuget/v3/flat2/microsoft.csharp/index.json'.
  An error occurred while sending the request.
    Unable to read data from the transport connection: Connection reset by peer.
    Connection reset by peer
  Retrying 'FindPackagesByIdAsync' for source 'https://pkgs.dev.azure.com/azure-public/3ccf6661-f8ce-4e8a-bb2e-eff943ddd3c7/_packaging/58ca65bb-e6c1-4210-88ac-fa55c1cd7877/nuget/v3/flat2/microsoft.extensions.dependencyinjection/index.json'.
  No route to host (pkgs.dev.azure.com:443)
    No route to host
  Retrying 'FindPackagesByIdAsync' for source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/9c2ea29a-00e0-4bae-b470-161fdab1f360/nuget/v3/flat2/microsoft.extensions.options/index.json'.
  No route to host (pkgs.dev.azure.com:443)
    No route to host

.azure/pipelines/ci.yml

dougbu · 2021-07-18T01:13:59Z

.azure/pipelines/ci.yml

+          inputs:
+            key: 'pw | "$(Agent.OS)" | eng/versions.props'
+            restoreKeys: |
+               pw | "$(Agent.OS)"


Why fallback to whatever Playwright version has been cached❔ Suggest leaving restoreKeys out

dougbu · 2021-07-18T01:15:20Z

.azure/pipelines/ci.yml

+            cacheHitVar: CACHE_PLAYWRIGHT_HIT
+          displayName: Cache playwright browsers
+        - script: npm i -D playwright
+          condition: ne(variables['CACHE_PLAYWRIGHT_HIT'], 'true')


Why does the Helix test job need Playwright❔ Suggest leaving this job alone

Well the quarantined version of helix will need it, and eventually the real one too

Don't we do Playwright installation on the Helix agents❔ I could understand this if the installations were uploaded from the build agents.

Right now it does it both on the helix machines but also as part of local builds/tests since the developer workflow is a thing too, generally it doesn't look like our builds are factored in a way that makes it easy to optionally install dependencies. I had to do some magic with conditional compilation for that to work on helix, so its possible but currently we aren't setup to easily stop installing playwright on builds

dougbu · 2021-07-18T01:21:48Z

.azure/pipelines/ci.yml

@@ -659,6 +661,17 @@ stages:
        beforeBuild:
        - powershell: "& ./src/Servers/IIS/tools/UpdateIISExpressCertificate.ps1; & ./src/Servers/IIS/tools/update_schema.ps1"
          displayName: Setup IISExpress test certificates and schema
+        - task: Cache@2
+          inputs:
+            key: 'pw | "$(Agent.OS)" | eng/versions.props'


eng/Versions.props doesn't list the npm package version for Playwright. I'm not sure where the version is stored. @javiercn❔ If we just use the latest, caching would be a Bad Thing:tm:.

Co-authored-by: Doug Bunting <[email protected]>

HaoK · 2021-08-04T17:25:31Z

@MattGal I'm still seeing an error with restore due to this 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/7d9f5c21-0d79-403f-bfe3-9a4506529760/nuget/v3/flat2/netstandard.library/index.json' not existing, is something bad cached in this PR maybe?

MattGal · 2021-08-09T17:27:08Z

@MattGal I'm still seeing an error with restore due to this 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/7d9f5c21-0d79-403f-bfe3-9a4506529760/nuget/v3/flat2/netstandard.library/index.json' not existing, is something bad cached in this PR maybe?

I've been OOF, taking a look.

MattGal · 2021-08-09T17:31:32Z

@HaoK I'm happy to look at whatever but I need a link, the only runs I can quickly find are failing just for ENOENT: no such file or directory, lstat '/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebKitLegacy.framework/Versions/Versions'

HaoK · 2021-08-09T17:33:19Z

Yeah that's my question, I constantly get those errors only, and its just specific to this PR where you said before it was a "(new variant, same problem)"

HaoK · 2021-08-09T18:59:27Z

/azp run

azure-pipelines · 2021-08-09T19:00:05Z

Azure Pipelines successfully started running 2 pipeline(s).

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 15, 2021

HaoK force-pushed the haok/pwcache branch 2 times, most recently from caf55eb to cc5a930 Compare July 15, 2021 01:12

dougbu reviewed Jul 18, 2021

View reviewed changes

HaoK force-pushed the haok/pwcache branch 2 times, most recently from 9b290f4 to b3fa42b Compare July 26, 2021 17:15

HaoK and others added 10 commits July 26, 2021 10:16

Try caching playwright browsers download

e8f535d

Update ci.yml

7230186

Update ci.yml

e00037c

Update ci.yml

d3f00fd

Update ci.yml

82247b3

Update ci.yml

8ed1c41

Update ci.yml

32020de

Update ci.yml

275bb2b

Update .azure/pipelines/ci.yml

b3fa42b

Co-authored-by: Doug Bunting <[email protected]>

Remove restore keys

7a4763b

HaoK mentioned this pull request Aug 11, 2021

playwright Failed to download firefox #33527

Closed

HaoK closed this Sep 29, 2021

HaoK deleted the haok/pwcache branch October 1, 2021 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try caching playwright browsers download #33557

Try caching playwright browsers download #33557

HaoK commented Jun 15, 2021

HaoK commented Jun 15, 2021

azure-pipelines bot commented Jun 15, 2021

HaoK commented Jul 15, 2021

HaoK commented Jul 15, 2021

azure-pipelines bot commented Jul 15, 2021

HaoK commented Jul 15, 2021

wtgodbe commented Jul 16, 2021

riarenas commented Jul 16, 2021

MattGal commented Jul 16, 2021

dougbu Jul 18, 2021

dougbu Jul 18, 2021

HaoK Jul 18, 2021

dougbu Jul 18, 2021

HaoK Jul 19, 2021

dougbu Jul 18, 2021

HaoK commented Aug 4, 2021

MattGal commented Aug 9, 2021

MattGal commented Aug 9, 2021

HaoK commented Aug 9, 2021

HaoK commented Aug 9, 2021

azure-pipelines bot commented Aug 9, 2021

Try caching playwright browsers download #33557

Try caching playwright browsers download #33557

Conversation

HaoK commented Jun 15, 2021

HaoK commented Jun 15, 2021

azure-pipelines bot commented Jun 15, 2021

HaoK commented Jul 15, 2021

HaoK commented Jul 15, 2021

azure-pipelines bot commented Jul 15, 2021

HaoK commented Jul 15, 2021

wtgodbe commented Jul 16, 2021

riarenas commented Jul 16, 2021

MattGal commented Jul 16, 2021

dougbu Jul 18, 2021

Choose a reason for hiding this comment

dougbu Jul 18, 2021

Choose a reason for hiding this comment

HaoK Jul 18, 2021

Choose a reason for hiding this comment

dougbu Jul 18, 2021

Choose a reason for hiding this comment

HaoK Jul 19, 2021

Choose a reason for hiding this comment

dougbu Jul 18, 2021

Choose a reason for hiding this comment

HaoK commented Aug 4, 2021

MattGal commented Aug 9, 2021

MattGal commented Aug 9, 2021

HaoK commented Aug 9, 2021

HaoK commented Aug 9, 2021

azure-pipelines bot commented Aug 9, 2021