Skip to content

Onboard Package Validation SDK #34122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+12 −1
Closed

Onboard Package Validation SDK #34122

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6031406
Onboard Package Validation SDK
wtgodbe Jul 6, 2021
c769428
Set BaselinePackageVersion
wtgodbe Jul 7, 2021
e07150c
updating to latest package version
Anipik Jul 14, 2021
152f444
Merge branch 'main' into wtgodbe/PackageValidation
Anipik Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Directory.Build.targets
View file
Original file line number Diff line number Diff line change
@@ -68,6 +68,13 @@

<Import Project="eng\Baseline.Designer.props" />

<!-- Properties for Package Validation -->
<PropertyGroup>
<PackageValidationBaselineVersion>$(BaselinePackageVersion)</PackageValidationBaselineVersion>
<!-- We only want to check for API changes in servicing branches -->
<DisablePackageBaselineValidation Condition=" '$(IsServicingBuild)' != 'true' ">true</DisablePackageBaselineValidation>
</PropertyGroup>

<PropertyGroup Condition=" '$(IsPackable)' != 'false' AND '$(IsServicingBuild)' == 'true' ">
<IsPackageInThisPatch Condition="'$(IsPackageInThisPatch)' == ''">true</IsPackageInThisPatch>
<!-- Used to distinguish between packages building -->
1 change: 1 addition & 0 deletions eng/Versions.props
View file
Original file line number Diff line number Diff line change
@@ -193,6 +193,7 @@
<MicrosoftCodeAnalysisCSharpWorkspacesVersion>3.8.0</MicrosoftCodeAnalysisCSharpWorkspacesVersion>
<MicrosoftCodeAnalysisPublicApiAnalyzersVersion>3.3.0</MicrosoftCodeAnalysisPublicApiAnalyzersVersion>
<MicrosoftCssParserVersion>1.0.0-20200708.1</MicrosoftCssParserVersion>
<MicrosoftDotNetPackageValidationVersion>1.0.0-preview.7.21364.16</MicrosoftDotNetPackageValidationVersion>
<MicrosoftIdentityModelLoggingVersion>6.10.0</MicrosoftIdentityModelLoggingVersion>
<MicrosoftIdentityModelProtocolsOpenIdConnectVersion>6.10.0</MicrosoftIdentityModelProtocolsOpenIdConnectVersion>
<MicrosoftIdentityModelProtocolsWsFederationVersion>6.10.0</MicrosoftIdentityModelProtocolsWsFederationVersion>
2 changes: 2 additions & 0 deletions eng/targets/CSharp.Common.props
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<Project>

<Sdk Name="Microsoft.DotNet.PackageValidation" Version="$(MicrosoftDotNetPackageValidationVersion)" />

<PropertyGroup>
<LangVersion>10.0</LangVersion>

3 changes: 2 additions & 1 deletion global.json
View file
Original file line number Diff line number Diff line change
@@ -31,6 +31,7 @@
"msbuild-sdks": {
"Yarn.MSBuild": "1.22.10",
"Microsoft.DotNet.Arcade.Sdk": "6.0.0-beta.21357.3",
"Microsoft.DotNet.Helix.Sdk": "6.0.0-beta.21357.3"
"Microsoft.DotNet.Helix.Sdk": "6.0.0-beta.21357.3",
"Microsoft.DotNet.PackageValidation": "$(MicrosoftDotNetPackageValidationVersion)"
}
}