Skip to content

Fix test to catch QUIC abort exception #34298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix test to catch QUIC abort exception #34298

merged 1 commit into from
Jul 13, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 13, 2021 •
edited
Loading

Might still be flakey from QUIC but at least on my computer the test is reliably doing the right thing: throwing abort exception.

@JamesNK JamesNK requested a review from Tratcher July 13, 2021 01:11
@ghost ghost added the area-runtime label Jul 13, 2021
@JamesNK JamesNK merged commit 5753baf into main Jul 13, 2021
@JamesNK JamesNK deleted the jamesnk/quicabort-reaction branch July 13, 2021 07:53
@ghost ghost added this to the 6.0-preview7 milestone Jul 13, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesNK @davidfowl @amcasey