Skip to content

Update license from Apache to MIT #34573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 23, 2021
Merged

Update license from Apache to MIT #34573

merged 8 commits into from
Jul 23, 2021

Conversation

Pilchie
Copy link
Member

@Pilchie Pilchie commented Jul 21, 2021

Fixes #18873.

Most work done by either Find and Replace or the Visual Studio fix to add missing headers.

@Pilchie
Copy link
Member Author

Pilchie commented Jul 21, 2021 •
edited
Loading

I suggest reviewing commit by commit, and skipping the second and last third commits as they are fairly mechanical.

@Pilchie
Copy link
Member Author

Pilchie commented Jul 21, 2021

@sharwell @richlander @ChrisSfanos

Pilchie
Pilchie commented Jul 21, 2021
View reviewed changes
src/Components/test/E2ETest/package.json
@@ -10,7 +10,7 @@
"sauce": "ts-node ./scripts/sauce.ts"
},
"author": "",
"license": "Apache-2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of package.json files with author of empty or Microsoft, should those be updated?

src/Installers/Debian/Runtime/debian_config.json.in
@@ -22,10 +22,10 @@
"architecture":"any"
},

"copyright": "Microsoft",
"copyright": ".NET Foundation and Contributors",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right thing to do? @dleeapho ?

src/Mvc/Settings.StyleCop Outdated
<Analyzer AnalyzerId="StyleCop.KRules.FileHeaderRule">
<Rules />
<AnalyzerSettings>
<StringProperty Name="FileHeaderText"> Copyright (c) Microsoft Open Technologies, Inc. All rights reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.</StringProperty>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured this was no longer relevant

@BrennanConroy
Copy link
Member

Are we going to handle non cs files later?

@Pilchie
Copy link
Member Author

Pilchie commented Jul 21, 2021

Are we going to handle non cs files later?

The Find and Replace step got them. I did a git grep Apache and walked through the results, and AFAICT, everything remaining after this is redists of other cases (like jquery).

@BrennanConroy
Copy link
Member

Oh, probably the second commit, which we can't really look at :D

@Pilchie
Copy link
Member Author

Pilchie commented Jul 21, 2021

Yes, that's my expectation.

@Pilchie
Copy link
Member Author

Pilchie commented Jul 21, 2021

git show 3dbb4f19f6 --name-only | findstr .java | measure-object confirms it (and other extensions too)

@BrennanConroy
Copy link
Member

Looks like this wasn't done properly:
https://github.com/dotnet/aspnetcore/blob/e954b6aef98408a7b672c7ce31e8dad0b24345f8/src/SignalR/clients/java/signalr/build.gradle#L34-L36

@pranavkm
Copy link
Contributor

pranavkm commented Jul 21, 2021 •
edited
Loading

#yolo approval. I can't quite review all the files, but the general gist of it seems right.

@Pilchie I would recommend starting starting the editorconfig rule as a suggestion and doing a second pass that turns in to warnings and clearing up the build warnings. Less chances that you run in to perpetual file conflicts that way.

@Pilchie
Copy link
Member Author

Pilchie commented Jul 21, 2021

@dotnet/aspnet-build Looks like some provisioning failures here. What's the best way to re-run?

@pranavkm
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 21, 2021
This was referenced Jul 21, 2021
Closed
Closed
@Pilchie
Copy link
Member Author

Pilchie commented Jul 23, 2021

It's green - going to merge!

@Pilchie Pilchie merged commit 8b30d86 into dotnet:main Jul 23, 2021
@ghost ghost added this to the 6.0-rc1 milestone Jul 23, 2021
@Pilchie Pilchie deleted the mit-license branch July 23, 2021 02:22
@Pilchie Pilchie mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging this pull request may close these issues.

Switch to MIT license
3 participants
@Pilchie @BrennanConroy @pranavkm