Remove async state machines from middlewares when they do nothing #34581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
ghost
added
area-runtime
community-contribution
Tratcher
reviewed
Jul 21, 2021
src/Middleware/HttpOverrides/src/HttpMethodOverrideMiddleware.cs
Outdated
Show resolved
Hide resolved
campersau
force-pushed
the
middlewareasyncstatemachines
branch
from
cae13b2 to
ca4bbc4
Compare
Tratcher
approved these changes
Jul 22, 2021
halter73
reviewed
Jul 22, 2021
| return _next(context); | ||
| } | ||
|
|
||
| private async Task InvokeCore(HttpContext context, string matchedPath, string remainingPath) |
There was a problem hiding this comment.
In Kestrel we often use the "Awaited" suffix to indicate why we're using this patter. So this would be InvokeAwaited. I'm okay with taking this as-is though.
halter73
approved these changes
Jul 22, 2021
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Remove async state machines from middlewares when they do nothing
PR Description
Searched for
await _next(and found a couple more in src\Http and src\MiddlewareFixes #34574