Add some shadow copy info #35201
Merged
Add some shadow copy info #35201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Tratcher
approved these changes
Aug 10, 2021
halter73
reviewed
Aug 10, 2021
| * This is done by resetting a timer each time a dll is changed, eventually triggering the timer once there are no dll changes. Afterwards, shutdown is started, | ||
| * causing the process to recycle. | ||
|
|
||
| * Subfolders are created under the user specified shadowCopyDirectory, where the highest int value directory name will be used each time. |
There was a problem hiding this comment.
I assume that if directory '1' exists but '0' doesn't, '0' will be used and '1' will be deleted. Is that the case?
There was a problem hiding this comment.
That's a good question, I'll add a new shadowcopy test to see what happens, I know that it does go and clean up old directories, but I'm not sure if it will look for gaps like that, I'd sort of assume it would use '2' to keep increasing
There was a problem hiding this comment.
Yeah see #35249 for the new test so the behavior is '1' will be used, and then '2' will be used on the next modification, so its always incrementally increasing using the highest integer for the next location (copied on shutdown).
halter73
approved these changes
Aug 10, 2021
adityamandaleeka
approved these changes
Aug 11, 2021
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/applicationinfo.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/applicationinfo.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Aditya Mandaleeka <[email protected]>
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.