Set IsRequired on ApiDescriptions for endpoints #35233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the same logic we have in RequestDelegateFactory.Create to determine if a method parameter is required or not. We then set the IsRequired property on the ApiParameterDesciption.
ghost
added
the
area-mvc
davidfowl
added
feature-minimal-actions
davidfowl
changed the title
halter73
reviewed
Aug 10, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Show resolved
Hide resolved
Co-authored-by: Stephen Halter <[email protected]>
halter73
approved these changes
Aug 11, 2021
amcasey
added
the
area-minimal
danmoseley
removed
the
old-area-web-frameworks-do-not-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
determine if a method parameter is required or not. We then set the
IsRequired property on the ApiParameterDesciption.
Fixes #35081
TODO: Figure out why tests don't properly expose NRT metadata. It might be because of this bug dotnet/roslyn#55254