Add Support for DateOnly & TimeOnly for SupplyParameterFromQuery
#35569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanayParikh
requested review from
SteveSandersonMS,
javiercn and
MackinnonBuck
ghost
added
the
TanayParikh
commented
Aug 20, 2021
| @@ -10,7 +12,6 @@ | |||
| <p> | |||
| Links: | |||
| <a href="WithQueryParameters/@FirstName?intvalue=123">With IntValue</a> | | |||
| <a href="WithQueryParameters/@FirstName?intvalue=123&NullableDateTimeValue=@(new DateTime(2000, 1, 2, 3, 4, 5, 6).ToString("u"))">With NullableDateTimeValue</a> | | |||
There was a problem hiding this comment.
This wasn't being utilized anywhere.
pranavkm
approved these changes
Aug 23, 2021
TanayParikh
commented
Aug 23, 2021
Comment on lines
30
to
31
| "dateonly" => typeof(DateOnly), | ||
| "timeonly" => typeof(TimeOnly), |
There was a problem hiding this comment.
Removed this, will be done in #34591
Comment on lines
811
to
808
| SetUrlViaPushState($"/WithQueryParameters/Abc?&NullableDateTimeValue={dateTime.ToString("u")}&NullableDateOnlyValue={dateOnly.ToString("u")}&NullableTimeOnlyValue={timeOnly.ToString("u")}"); | ||
| SetUrlViaPushState($"/WithQueryParameters/Abc?NullableDateTimeValue=2000-01-02%2003:04:05&NullableDateOnlyValue=2000-01-02&NullableTimeOnlyValue=03:04:05"); |
There was a problem hiding this comment.
Constructing URL via interpolation was causing issues (due to localization / date cultures). Testing with a hard-coded string for now.
|
/backport to release/6.0-rc1 |
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1160172691 |
10 tasks
pranavkm
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35525
API Proposal Fixes: #35567