-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Minimal APIs naming cleanup #35570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal APIs naming cleanup #35570
Conversation
Thank you for your API proposal. I'm removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You gonna backport this? |
Yep. I'm just trying to follow the proper process. |
|
Good catch @Kahbazi 👍 |
There's also some hard-coded string in analyzer.
|
1b1ec11
to
b1c0d85
Compare
I don't know if it counts, but an analyzer also has minimal actions in public API: |
I'm not sure if it counts either, but I renamed |
/backport to release/6.0-rc1 |
Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1152365695 |
7403a5e
to
3b2ae74
Compare
This avoids using "Minimal" in any API names and avoids using "action" when defining minimal route handlers.
MinimalActionEndpointRouteBuilderExtensions
->DelegateEndpointRouteBuilderExtensions
MinimalActionEndpointConventionBuilder
->DelegateEndpointConventionBuilder
Map(this IEndpointRouteBuilder endpoints, RoutePattern pattern, Delegate action)
->Map(this IEndpointRouteBuilder endpoints, RoutePattern pattern, Delegate handler)
Once this is merged, I'll backport for rc1 since this is a breaking change.
Fixes #35478