[release/6.0-rc1] Update middleware that assumes UseRouting is called after them, for minimal hosting #35635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
BrennanConroy and
Tratcher
as code owners
ghost
added
the
Co-authored-by: Stephen Halter <[email protected]>
davidfowl
reviewed
Aug 24, 2021
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
BrennanConroy
added
Servicing-approved
halter73
approved these changes
Aug 24, 2021
BrennanConroy
approved these changes
Aug 24, 2021
|
@dotnet/aspnet-build merge please 😃 |
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35426 to release/6.0-rc1
/cc @BrennanConroy
Customer Impact
When using the new "minimal hosting" (WebApplicationBuilder/WebApplication),
UseRouting()is implicitly called for you which causes issues if you try to use one of the middleware that should run beforeUseRouting(middleware order). If you hit this scenario where you use one of these middleware without callingUseRoutingit will silently not work. This fixes it so the middleware will work in the WebApplication case without the user callingUseRouting.Testing
Lots of new tests for both new and old scenarios
Risk
Low, test coverage is good, manual testing done as well.