Skip to content

Always download blazor-hotreload.js from app root #35737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

pranavkm
Copy link
Contributor

The middleware that we inject always listens to the root of the app while the module is imported from relative path. Changing this to be root relative. We do something similar with the aspnet-browser-refresh.js script and haven't had issues with it so far.

Fixes #35555

The middleware that we inject always listens to the root of the app. While this might not play very nicely if the app
is running off a virtual path, listening to the root is what we do with the aspnet-browser-refresh.js script and we've had no issue
reports with it thus far.

Fixes #35555
@pranavkm pranavkm requested a review from a team as a code owner August 25, 2021 21:18
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 25, 2021
@pranavkm pranavkm enabled auto-merge (squash) August 25, 2021 22:18
@pranavkm pranavkm merged commit abdc2a2 into main Aug 25, 2021
@pranavkm pranavkm deleted the prkrishn/35555 branch August 25, 2021 22:53
@ghost ghost added this to the 7.0-preview1 milestone Aug 25, 2021
@pranavkm
Copy link
Contributor Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1263792745

@github-actions
Copy link
Contributor

@pranavkm an error occurred while backporting to release/6.0, please check the run log for details!

Error: @pranavkm is not a repo collaborator, backporting is not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hotreload breaks blazor webassembly with asp and user defined base path - missing blazor-hotreload.js returns 404
2 participants