Skip to content

Update facebook oauth to v11.0 #36284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Sep 8, 2021

Contributes to #4684

We update these values to their latest each release to prevent warnings from using outdated versions. No behavior changes were observed.

I also tested Twitter, Google, and Microsoft, but no updates were required there.

Backport to .NET 6

@Tratcher Tratcher added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Sep 8, 2021
@Tratcher Tratcher added this to the 7.0-preview1 milestone Sep 8, 2021
@Tratcher Tratcher self-assigned this Sep 8, 2021
@Tratcher Tratcher requested a review from HaoK September 8, 2021 16:10

/// <summary>
/// The Facebook Graph API endpoint that is used to gather additional user information.
/// </summary>
public static readonly string UserInformationEndpoint = "https://graph.facebook.com/v8.0/me";
public static readonly string UserInformationEndpoint = "https://graph.facebook.com/v11.0/me";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amusing v8 -> v11 since we last did this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They rev the version about every 6 months, and we did the update a little earlier in 5.0.

@Tratcher Tratcher merged commit 2f02f3d into dotnet:main Sep 8, 2021
@Tratcher Tratcher deleted the tratcher/oauth branch September 8, 2021 18:15
@Tratcher
Copy link
Member Author

Tratcher commented Sep 8, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1214448737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants