Skip to content

Switch to 1ES R&D Pools on main #36820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

Switch to 1ES R&D Pools on main #36820

merged 1 commit into from
Sep 22, 2021

Conversation

jonfortescue
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Switch to 1ES R&D Pools on main
We need to switch to the 1ES pools. This does that on main.

Tracking issue: https://github.com/dotnet/core-eng/issues/14276

@jonfortescue jonfortescue requested a review from a team as a code owner September 21, 2021 21:51
@jonfortescue jonfortescue self-assigned this Sep 21, 2021
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 21, 2021
ulisesh
ulisesh approved these changes Sep 21, 2021
View reviewed changes
Copy link

@ulisesh ulisesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dougbu
dougbu approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonfortescue❕

@dougbu
Copy link
Contributor

dougbu commented Sep 22, 2021

@jonfortescue please let us know if you need help merging

@jonfortescue
Copy link
Contributor Author

@dougbu looks like I have permissions to merge! Doing that now.

@jonfortescue jonfortescue merged commit f7dc5e2 into dotnet:main Sep 22, 2021
@ghost ghost added this to the 7.0-preview1 milestone Sep 22, 2021
@jonfortescue jonfortescue deleted the SwitchTo1esPools branch September 22, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatalas lpatalas Awaiting requested review from lpatalas

@NTaylorMullen NTaylorMullen Awaiting requested review from NTaylorMullen

2 more reviewers

@dougbu dougbu dougbu approved these changes

@ulisesh ulisesh ulisesh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jonfortescue jonfortescue

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@jonfortescue @dougbu @ulisesh