Backport Blazor Stop Requiring unsafe-inline in CSP (#36771)
#36846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Blazor Server Allow Unsafe Inline For: #34428 * Update MonoPlatform.ts * Fix DefaultReconnectDisplay.test * PR Feedback
ghost
added
the
|
@Pilchie requesting approval to merge for 6.0 |
|
Approved for .NET 6.0 |
|
Thanks Kevin. @dotnet/aspnet-build requesting merge into 6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to the Blazor Server reconnection handler such that it uses DOM based APIs so that the
unsafe-inlinecondition is no longer required on the Content Security Policy (CSP). This empowers customers to create stricter CSP controls in their Blazor applications.Customer Impact
Blazor wasn't CSP compliant, meaning for those who wanted to enable CSP, they needed to add
unsafe-inlinewhich diminishes a lot of the benefits of having CSP in the first place.Regression?
[If yes, specify the version the behavior has regressed from]
Risk
Actual changes are just to use the DOM APIs to generate the elements, instead of dynamically injecting HTML. This should reduce overall product risk as it's using more generally accepted practices.
Verification
Packaging changes reviewed?
Addresses #34428
Original PR: #36771