Skip to content

Update WiX to signed build #36865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

Update WiX to signed build #36865

merged 1 commit into from
Sep 23, 2021

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Sep 22, 2021 •
edited
Loading

@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Sep 22, 2021
@dougbu dougbu requested review from joeloff and a team September 22, 2021 23:29
@dougbu
Copy link
Contributor Author

dougbu commented Sep 22, 2021 •
edited
Loading

@dougbu
Copy link
Contributor Author

dougbu commented Sep 22, 2021

Oops, wrong reference. Issue is #36854

@dougbu dougbu mentioned this pull request Sep 22, 2021
Closed
@joeloff
Copy link
Member

joeloff commented Sep 23, 2021

wixstdba was one of the main pain points. It's been signed for a while now since we moved to 3.14, except now it will have multiple authenticode signatures. You should be able to clear out some of the other exclusions for WiX as well.

The recommendation for the build from source is still fine as long as that points people to 3.14 since that's the minimum requirement if you're trying to build for arm64. The only difference is that our copy of the toolset we use internally is signed by Microsoft and WiX. Functionally speaking, it's the official 3.14.0.4118 build (hence two versions in the semver to track our build process and reflect the official WiX build at the same time).

@dougbu
Copy link
Contributor Author

dougbu commented Sep 23, 2021

You should be able to clear out some of the other exclusions for WiX as well.

@mmitche w/ post-build signing and much later validations, is there a quick way to check whether removing https://github.com/dotnet/aspnetcore/blob/release/6.0-rc2/eng/SignCheckExclusionsFile.txt entries breaks anything❔

@dougbu dougbu merged commit a96feda into release/6.0-rc2 Sep 23, 2021
@dougbu dougbu deleted the dougbu/microsoft.wix.12078 branch September 23, 2021 16:29
@dougbu
Copy link
Contributor Author

dougbu commented Sep 23, 2021

Merging now. We can experiment w/ SignCheckExclusionsFile.txt after I understand how to verify things e2e e.g. once we're looking at 'main'

@dougbu dougbu added this to the 6.0-rc2 milestone Sep 23, 2021
@mmitche
Copy link
Member

mmitche commented Sep 23, 2021

You should be able to clear out some of the other exclusions for WiX as well.

@mmitche w/ post-build signing and much later validations, is there a quick way to check whether removing https://github.com/dotnet/aspnetcore/blob/release/6.0-rc2/eng/SignCheckExclusionsFile.txt entries breaks anything❔

  • @adiaaida
    The nightly validation builds should catch that I think.

@ghost
Copy link

ghost commented Sep 23, 2021

Hi @mmitche. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

BrennanConroy added a commit that referenced this pull request Sep 24, 2021
@BrennanConroy @dougbu
@pranavkm @captainsafia @halter73 @wtgodbe
[automated] Merge branch 'release/6.0-rc2' => 'release/6.0' (#36901)
e00c244 
* Update WiX to signed build (#36865)

- #12078

* Always download blazor-hotreload.js from app root (#36897)

The middleware that we inject always listens to the root of the app. While this might not play very nicely if the app
is running off a virtual path, listening to the root is what we do with the aspnet-browser-refresh.js script and we've had no issue
reports with it thus far.

Fixes #35555

* Improve Results.Problem and Results.ValidationProblem APIs (#36856)

* [release/6.0-rc2] Update sdk to 6.0.100-rc.2.21470.55 (#36783)

* Update sdk to 6.0.100-rc.2.21470.55

Co-authored-by: Will Godbe <[email protected]>

Co-authored-by: Doug Bunting <[email protected]>
Co-authored-by: Pranav K <[email protected]>
Co-authored-by: Safia Abdalla <[email protected]>
Co-authored-by: Stephen Halter <[email protected]>
Co-authored-by: Will Godbe <[email protected]>
Co-authored-by: Brennan <[email protected]>
@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

When does this change hit main? Can we manually port?

@dotnet dotnet deleted a comment Oct 6, 2021
@BrennanConroy
Copy link
Member

When does this change hit main? Can we manually port?

It wont unless you manually port

@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

/backport to main

@ghost
Copy link

ghost commented Oct 6, 2021

Hi @ericstj. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/1310479769

@github-actions github-actions bot mentioned this pull request Oct 6, 2021
Merged
ericstj pushed a commit to ericstj/aspnetcore that referenced this pull request Oct 8, 2021
@dougbu @ericstj
Update WiX to signed build (dotnet#36865)
c381474 
- dotnet#12078
ericstj pushed a commit to ericstj/aspnetcore that referenced this pull request Oct 8, 2021
@dougbu @ericstj
Update WiX to signed build (dotnet#36865)
a394985 
- dotnet#12078
dougbu added a commit that referenced this pull request Oct 11, 2021
@ericstj @github-actions @dougbu
[release/5.0] Backport x64 on ARM64 installer changes (#37407)
b3238fb 
* [release/6.0-rc2] Retarget DOTNETHOME when installing x64 on ARM64 (#36695)

* Retarget DOTNETHOME when installing x64 on ARM64

* Make platform comparison case insenstive

* Address feedback

* Install x64 registry keys to different path on ARM64 machine

Co-authored-by: Eric StJohn <[email protected]>

* Update WiX to signed build (#36865)

- #12078

* Update wix to 1.0.0-v3.14.0.5722 (#37329)

Co-authored-by: Eric StJohn <[email protected]>

* [release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine (#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in #37290

Co-authored-by: Eric StJohn <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
dougbu added a commit that referenced this pull request Oct 11, 2021
@ericstj @github-actions @dougbu
[release/3.1] Backport x64 on ARM64 installer changes (#37409)
730a662 
* [release/6.0-rc2] Retarget DOTNETHOME when installing x64 on ARM64 (#36695)

* Retarget DOTNETHOME when installing x64 on ARM64

* Make platform comparison case insenstive

* Address feedback

* Install x64 registry keys to different path on ARM64 machine

Co-authored-by: Eric StJohn <[email protected]>

* Update WiX to signed build (#36865)

- #12078

* Update wix to 1.0.0-v3.14.0.5722 (#37329)

Co-authored-by: Eric StJohn <[email protected]>

* [release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine (#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in #37290

Co-authored-by: Eric StJohn <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@joeloff joeloff Awaiting requested review from joeloff

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
6.0-rc2
Development

Successfully merging this pull request may close these issues.
6 participants
@dougbu @joeloff @mmitche @ericstj @BrennanConroy @wtgodbe