Skip to content

Backport Blazor Server Add Console Warning if Long Polling (#36764) #36886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Sep 23, 2021

Description

In RC2, we reverted enforcing WebSocket based transports via #36656.

This PR adds back some error messages, along with a new warning message specifically mentioning that Long Polling is being utilized.

Customer Impact

Adds additional console warnings to notify users/developers that they're utilizing Long Polling, and provides links for additional information. This is to encourage customers to switch to WebSockets which provides a significantly improved end-user experience.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Added console warnings.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

Addresses #36817
PR: #36764

* Blazor Server Add Console Error if Long Polling

* E2E Testing

* Fix tests

* Update Boot.Server.ts
@TanayParikh TanayParikh requested a review from a team as a code owner September 23, 2021 16:05
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Sep 23, 2021
@TanayParikh TanayParikh requested a review from Pilchie September 23, 2021 16:06
@TanayParikh
Copy link
Contributor Author

@Pilchie requesting consideration for .NET 6.0

@TanayParikh TanayParikh changed the title Blazor Server Add Console Warning if Long Polling (#36764) Backport Blazor Server Add Console Warning if Long Polling (#36764) Sep 23, 2021
@Pilchie
Copy link
Member

Pilchie commented Sep 23, 2021

Approved for .NET 6.

@TanayParikh
Copy link
Contributor Author

Thanks Kevin.

@dotnet/aspnet-build requesting merge.

@BrennanConroy BrennanConroy enabled auto-merge (squash) September 23, 2021 18:50
@BrennanConroy BrennanConroy merged commit 16e08a6 into release/6.0 Sep 23, 2021
@BrennanConroy BrennanConroy deleted the taparik/backportc17f75d34a branch September 23, 2021 18:52
@ghost ghost added this to the 6.0.0 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants