Skip to content

Add / update PR templates #37412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .azuredevops/pull_request_template/branches/release.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# {PR title}

Summary of the changes (Less than 80 chars)

## Description

{Detail}

Fixes #{bug number} (in this specific format)

## Customer Impact

{Justification}

## Regression?

- [ ] Yes
- [ ] No

[If yes, specify the version the behavior has regressed from]

## Risk

- [ ] High
- [ ] Medium
- [ ] Low

[Justify the selection above]

## Verification

- [ ] Manual (required)
- [ ] Automated

## Packaging changes reviewed?

- [ ] Yes
- [ ] No
- [ ] N/A

----

## When servicing release/2.1

- [ ] Make necessary changes in eng/PatchConfig.props
13 changes: 13 additions & 0 deletions .azuredevops/pull_request_template/minimal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# {PR title}

<!--
Use for tell mode PRs after removing servicing template. Ignoring internal PRs targeting main (extreme corner case).
-->

Summary of the changes (Less than 80 chars)

## Description

{Detail}

Fixes #{bug number} (in this specific format)
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* @Pilchie
/global.json @dotnet/aspnet-build
/.azure/ @dotnet/aspnet-build
/.azuredevops/ @dotnet/aspnet-build
/.config/ @dotnet/aspnet-build
/.devcontainer/ @captainsafia
/.github/ @dotnet/aspnet-build
Expand Down
17 changes: 15 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE/servicing.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,45 @@
# {PR title}

Summary of the changes (Less than 80 chars)

## Description

{Detail}

Fixes #{bug number} (in this specific format)

## Customer Impact


{Justification}

## Regression?

- [ ] Yes
- [ ] No

[If yes, specify the version the behavior has regressed from]

## Risk

- [ ] High
- [ ] Medium
- [ ] Low

[Justify the selection above]

## Verification

- [ ] Manual (required)
- [ ] Automated

## Packaging changes reviewed?

- [ ] Yes
- [ ] No
- [ ] N/A

----

## When servicing release/2.1

Addresses [issue number]
- [ ] Make necessary changes in eng/PatchConfig.props
10 changes: 5 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# {PR title}

<!-- Thank you for submitting a pull request to our repo. -->

Expand All @@ -11,11 +12,10 @@ below to ensure a smooth review and merge process for your PR. -->

<!-- Once all that is done, you're ready to go. Open the PR with the content below. -->

**PR Title**
Summary of the changes (Less than 80 chars)

**PR Description**
Detail 1
Detail 2
## Description

Fixes #bugnumber (in this specific format)
{Detail}

Fixes #{bug number} (in this specific format)