Remove retries from BlazorWasm template tests & don't fail on restore errors #37715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
|
We can consider adding these to https://github.com/dotnet/aspnetcore/blob/main/eng/test-configuration.json#L9 at the same time, to give that more exercise with a real failing test? |
HaoK
approved these changes
Oct 20, 2021
dougbu
approved these changes
Oct 20, 2021
|
I suspect the Blazor tests reuse the same project and end up restoring them multiple times. It's possible, though unlikely, that obj/project.nuget.cache is actually part of the work item payload. Recommend checking for both. |
|
Updated so that blazor template tests don't fail on restore errors |
wtgodbe
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restore fails on these tests, we leave
nuget.g.props/targetsfiles on disk, causing subsequent restores to fail (on retry). Let's disable automatic retry for now - if we want to turn it back on, we should use the Helix retry functionality rather than our own. This just started causing test failures because we now exit with failure when restore fails, rather than exiting w/0.