Skip to content

Unskip signalr test #37894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

Unskip signalr test #37894

merged 1 commit into from
Oct 28, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Oct 28, 2021

Fixes #34563

@HaoK HaoK requested a review from BrennanConroy October 28, 2021 00:29
@HaoK HaoK requested a review from halter73 as a code owner October 28, 2021 00:29
@ghost ghost added the area-signalr Includes: SignalR clients and servers label Oct 28, 2021
@HaoK HaoK enabled auto-merge (squash) October 28, 2021 00:45
@HaoK
Copy link
Member Author

HaoK commented Oct 28, 2021

@dougbu another file in use failure, I won't rerun this for now since this is just an unskip PR

@dougbu
Copy link
Member

dougbu commented Oct 28, 2021

Must admit I'm not sure how to get information about file-in-use problems from cores such as https://dev.azure.com/dnceng/_apis/resources/Containers/8604460/MacOS_Test_Dumps?itemPath=MacOS_Test_Dumps%2Fdotnet-75074.1635382600.core. But, there's a binary log at https://dev.azure.com/dnceng/_apis/resources/Containers/8604460/MacOS_Test_Logs?itemPath=MacOS_Test_Logs%2FRelease%2FBuild.binlog

Broadly, @wtgodbe and I don't really have much context other than seeing the comments from people like @rainersigwald, @TanayParikh and @BrennanConroy as they worked through some instances of this problem. Suggest the Blops person (blooper 😁) should spend some time on these issues as part of the regular rotation.

Thoughts @dotnet/aspdoi❔

@dougbu
Copy link
Member

dougbu commented Oct 28, 2021

And, yes, we probably shouldn't have asked for a "callout" on #32219 problems 🤦

@HaoK HaoK merged commit deb6489 into main Oct 28, 2021
@HaoK HaoK deleted the haok/java branch October 28, 2021 04:10
@ghost ghost added this to the 7.0-preview1 milestone Oct 28, 2021
@dougbu dougbu mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

LongPollingTransportOnReceiveGetsCalled() is flaky
4 participants
@HaoK @dougbu @halter73 @BrennanConroy