Stop enforcing JSON read till end if EndInvokeJS returns early
#39060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanayParikh
requested review from
pranavkm and
a team
and removed request for
Pilchie
pranavkm
reviewed
Dec 15, 2021
src/JSInterop/Microsoft.JSInterop/src/Infrastructure/DotNetDispatcher.cs
Outdated
Show resolved
Hide resolved
TanayParikh
commented
Dec 15, 2021
| } | ||
|
|
||
| [Fact] | ||
| public void EndInvokeJS_ThrowsIfJsonIsEmptyString() |
There was a problem hiding this comment.
Remaining tests have been moved up from later in the file (so all the EndInvokeJS tests remain in one section). The Arrange section was also added for the tests.
pranavkm
reviewed
Dec 15, 2021
src/JSInterop/Microsoft.JSInterop/test/Infrastructure/DotNetDispatcherTest.cs
Show resolved
Hide resolved
pranavkm
approved these changes
Dec 15, 2021
TanayParikh
added a commit
that referenced
this pull request
Dec 16, 2021
) * mono_crash.*.blob * Stop enforcing read till end if EndInvoke returns early * Tests * Test name change * Fix tests * PR Feedback @pranavkm
This was referenced Dec 16, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to enforce we've read till the end of the JSON if we've just abandoned the
EndInvokeJScall entirely due to the task timing out or if it stopped waiting. If we abandoned theEndInvokeJScall, we know we haven't read till the end of the JSON (and that's expected), hence we shouldn't be throwing an exception in that case.Fixes: #38962