Enable IDE0059 #39434
Merged
Enable IDE0059 #39434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet#24055
pranavkm
requested review from
BrennanConroy,
captainsafia,
halter73,
javiercn,
Pilchie,
Tratcher and
a team
as code owners
Pilchie
added
the
area-infrastructure
TanayParikh
reviewed
Jan 11, 2022
| if (traitAttribute is ReflectionAttributeInfo attribute && attribute.Attribute is QuarantinedTestAttribute quarantinedTestAttribute) | ||
| if (traitAttribute is ReflectionAttributeInfo { Attribute: QuarantinedTestAttribute }) |
| var codeUnitCount = 1; | ||
| var expectValueMin = 0; | ||
| int currentDecodeBits; | ||
| int codeUnitCount; |
There was a problem hiding this comment.
Shouldn't this be:
int codeUnitCount = 1;?
| var byteCount = 1; | ||
| var expectValueMin = 0; | ||
| int currentDecodeBits; | ||
| int byteCount; |
src/Middleware/Spa/SpaServices.Extensions/src/Util/EventedStreamReader.cs
Show resolved
Hide resolved
Comment on lines
-213
to
-214
| Contract.Ensures((Contract.ValueAtReturn(out length) >= 0) && | ||
| (Contract.ValueAtReturn(out length) <= (input.Length - startIndex))); |
There was a problem hiding this comment.
Why is this no longer necessary here and below?
There was a problem hiding this comment.
AFAIK Code contracts don't work. They're left over from when this code was initially ported over. Right @Tratcher ?
Tratcher
approved these changes
Jan 13, 2022
ghost
added this to the 
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #24055