Skip to content

Adding warning log when no actions detected #39618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 19, 2022
Merged

Adding warning log when no actions detected #39618

merged 4 commits into from
Jan 19, 2022

Conversation

brunolins16
Copy link
Member

Fixes #39126

@brunolins16 brunolins16 requested a review from pranavkm January 18, 2022 21:56
@brunolins16 brunolins16 requested a review from javiercn as a code owner January 18, 2022 21:56
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 18, 2022
pranavkm
pranavkm reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks

@brunolins16 brunolins16 requested a review from pranavkm January 18, 2022 23:00
pranavkm
pranavkm approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the failing tests, you can use a NullLogger<T>.Instance.

@brunolins16 brunolins16 merged commit 15635f7 into dotnet:main Jan 19, 2022
@ghost ghost added this to the 7.0-preview1 milestone Jan 19, 2022
@brunolins16 brunolins16 deleted the brunolins16/issues/10611-log branch January 19, 2022 21:00
ShreyasJejurkar pushed a commit to ShreyasJejurkar/aspnetcore that referenced this pull request Jan 22, 2022
@brunolins16 @ShreyasJejurkar
Adding warning log when no actions detected (dotnet#39618)
083eee2 
* Adding warning log when no actions detected

* PR feeback

* Moving log method to a nested class

* Updating tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

Adding EntryAssembly to AddRazorPages/AddControllers*
2 participants
@brunolins16 @pranavkm