Skip to content

[release/6.0] Skip failing cert tests for now #39687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[release/6.0] Skip failing cert tests for now #39687

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #39670 to release/6.0

/cc @HaoK

{PR title}

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@github-actions github-actions bot requested a review from Tratcher as a code owner January 21, 2022 21:32
@ghost ghost added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jan 21, 2022
@ghost ghost added this to the 6.0.x milestone Jan 21, 2022
@ghost
Copy link

ghost commented Jan 21, 2022

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@HaoK HaoK requested a review from a team January 21, 2022 22:04
dougbu
dougbu approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of the longer-term fix of updating the relevant certificate❔

@dougbu
Copy link
Contributor

dougbu commented Jan 21, 2022

YARN(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) No Connection with that ID: Status code '404' in wwwroot/dist/signalr-functional-tests.js (line 2554)

@BrennanConroy I saw this error in another PR earlier today. Is there a workaround❔

@BrennanConroy
Copy link
Member

#39679

@dougbu
Copy link
Contributor

dougbu commented Jan 21, 2022

Suggest combining this PR (thanks @HaoK) and #39679 (thanks @BrennanConroy) into one. Otherwise, we'll likely waste time when the branch is next open. Ideal would be a single commit that can be cherry-picked into whatever branch targets 'release/6.0' and makes it easy to clean up their CI runs.

@dougbu
Copy link
Contributor

dougbu commented Jan 21, 2022

Also, suggest labeling this PR as tell-mode since it is test-only.

@HaoK HaoK added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 21, 2022
@dougbu dougbu mentioned this pull request Jan 24, 2022
Merged
@wtgodbe
Copy link
Member

wtgodbe commented Jan 24, 2022

I pushed these commits to #39679, closing in favor of that

@wtgodbe wtgodbe closed this Jan 24, 2022
@wtgodbe wtgodbe deleted the backport/pr-39670-to-release/6.0 branch January 24, 2022 21:11
@dougbu dougbu removed this from the 6.0.x milestone Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Awaiting requested review from Tratcher

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @BrennanConroy @wtgodbe @HaoK