Skip to content

Fix nearly all CS1591 #40106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 10, 2022
Merged

Fix nearly all CS1591 #40106

merged 7 commits into from
Feb 10, 2022

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Feb 9, 2022 •
edited
Loading

Fixes #27538

@pranavkm
Copy link
Contributor Author

pranavkm commented Feb 9, 2022

Bonus 💯 points if you find the doc bug.

@pranavkm @Tratcher @sharwell
Apply suggestions from code review
1e4691e 
Co-authored-by: Chris Ross <[email protected]>
Co-authored-by: Sam Harwell <[email protected]>
@Tratcher Tratcher self-requested a review February 9, 2022 23:39
pranavkm
pranavkm commented Feb 10, 2022
View reviewed changes
src/Servers/Connections.Abstractions/src/FileHandleType.cs
@@ -8,7 +8,18 @@ namespace Microsoft.AspNetCore.Connections;
/// </summary>
public enum FileHandleType
{
/// <summary>
/// This API is unused and no longer supported.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @Tratcher / @halter73. Doesn't appear to be used. David thought this might have been specific to Libuv.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 10, 2022
@pranavkm pranavkm merged commit a1c4694 into dotnet:main Feb 10, 2022
@pranavkm pranavkm deleted the cs1591 branch February 10, 2022 18:47
@ghost ghost added this to the 7.0-preview2 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell left review comments

@BrennanConroy BrennanConroy BrennanConroy left review comments

@JamesNK JamesNK JamesNK approved these changes

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-preview2
Development

Successfully merging this pull request may close these issues.

More API docs
6 participants
@pranavkm @JamesNK @sharwell @Tratcher @BrennanConroy @Pilchie