Skip to content

Skip Playwright Tests Running in Quarantined Pipeline #40129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Skip Playwright Tests Running in Quarantined Pipeline #40129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
798bca2
Skip Playwright Tests Running in Quarantined Pipeline
TanayParikh Feb 10, 2022
321b935
Fact -> Theory Skip
TanayParikh Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/ProjectTemplates/BlazorTemplates.Tests/BlazorServerTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory)

public override string ProjectType { get; } = "blazorserver";

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30761")]
[InlineData(BrowserKind.Chromium)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30761")]
public async Task BlazorServerTemplateWorks_NoAuth(BrowserKind browserKind)
{
var project = await CreateBuildPublishAsync("blazorservernoauth" + browserKind);
Expand Down Expand Up @@ -81,9 +80,8 @@ await BrowserManager.GetBrowserInstance(browserKind, BrowserContextInfo) :
public static IEnumerable<object[]> BlazorServerTemplateWorks_IndividualAuthData =>
BrowserManager.WithBrowsers(new[] { BrowserKind.Chromium }, true, false);

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[MemberData(nameof(BlazorServerTemplateWorks_IndividualAuthData))]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/30825", Queues = "All.OSX")]
public async Task BlazorServerTemplateWorks_IndividualAuth(BrowserKind browserKind, bool useLocalDB)
{
Expand Down Expand Up @@ -182,13 +180,12 @@ private async Task TestBasicNavigation(Project project, IPage page)
Assert.Equal(5, await page.Locator("p+table>tbody>tr").CountAsync());
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[InlineData("IndividualB2C", null)]
[InlineData("IndividualB2C", new string[] { "--called-api-url \"https://graph.microsoft.com\"", "--called-api-scopes user.readwrite" })]
[InlineData("SingleOrg", null)]
[InlineData("SingleOrg", new string[] { "--called-api-url \"https://graph.microsoft.com\"", "--called-api-scopes user.readwrite" })]
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public Task BlazorServerTemplate_IdentityWeb_BuildAndPublish(string auth, string[] args)
=> CreateBuildPublishAsync("blazorserveridweb" + Guid.NewGuid().ToString().Substring(0, 10).ToLowerInvariant(), auth, args);

Expand Down
21 changes: 7 additions & 14 deletions src/ProjectTemplates/BlazorTemplates.Tests/BlazorWasmTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ public BlazorWasmTemplateTest(ProjectFactoryFixture projectFactory)

public override string ProjectType { get; } = "blazorwasm";

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[InlineData(BrowserKind.Chromium)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public async Task BlazorWasmStandaloneTemplate_Works(BrowserKind browserKind)
{
var project = await CreateBuildPublishAsync("blazorstandalone" + browserKind);
Expand Down Expand Up @@ -60,9 +59,8 @@ private static async Task<IPage> NavigateToPage(IBrowserContext browser, string
return page;
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[InlineData(BrowserKind.Chromium)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public async Task BlazorWasmHostedTemplate_Works(BrowserKind browserKind)
{
var project = await CreateBuildPublishAsync("blazorhosted" + BrowserKind.Chromium, args: new[] { "--hosted" }, serverProject: true);
Expand Down Expand Up @@ -109,9 +107,8 @@ private static async Task AssertCompressionFormat(AspNetProcess aspNetProcess, s
Assert.Equal(expectedEncoding, response.Content.Headers.ContentEncoding.Single());
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[InlineData(BrowserKind.Chromium)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public async Task BlazorWasmStandalonePwaTemplate_Works(BrowserKind browserKind)
{
var project = await CreateBuildPublishAsync("blazorstandalonepwa", args: new[] { "--pwa" });
Expand Down Expand Up @@ -145,9 +142,8 @@ public async Task BlazorWasmStandalonePwaTemplate_Works(BrowserKind browserKind)
}
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[InlineData(BrowserKind.Chromium)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public async Task BlazorWasmHostedPwaTemplate_Works(BrowserKind browserKind)
{
var project = await CreateBuildPublishAsync("blazorhostedpwa", args: new[] { "--hosted", "--pwa" }, serverProject: true);
Expand Down Expand Up @@ -216,18 +212,16 @@ private static void ValidatePublishedServiceWorker(Project project)
Assert.True(serviceWorkerContents.Contains($"/* Manifest version: {serviceWorkerAssetsManifestVersion} */", StringComparison.Ordinal));
}

[ConditionalTheory]
[ConditionalTheory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[InlineData(BrowserKind.Chromium)]
// LocalDB doesn't work on non Windows platforms
[OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB(BrowserKind browserKind)
=> BlazorWasmHostedTemplate_IndividualAuth_Works(browserKind, true);

// This test depends on BlazorWasmTemplate_CreateBuildPublish_IndividualAuthNoLocalDb running first
[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
[InlineData(BrowserKind.Chromium)]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/30825", Queues = "All.OSX")]
public Task BlazorWasmHostedTemplate_IndividualAuth_Works_WithOutLocalDB(BrowserKind browserKind)
=> BlazorWasmHostedTemplate_IndividualAuth_Works(browserKind, false);
Expand Down Expand Up @@ -379,9 +373,8 @@ public TemplateInstance(string name, params string[] arguments)
public string[] Arguments { get; }
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/37782")]
[MemberData(nameof(TemplateData))]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/37782")]
public Task BlazorWasmHostedTemplate_AzureActiveDirectoryTemplate_Works(TemplateInstance instance)
=> CreateBuildPublishAsync(instance.Name, args: instance.Arguments, targetFramework: "netstandard2.1");

Expand Down