Increase a few IIS test timeouts #40884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- double all `HttpClient.Timeout` values - increate max. `TimeoutAfter(...)` timeout to 15 minutes (from 10) - double values that weren't 10 minutes - double `TestConnection.Timeout` and `IISExpressDeployer.ShutdownTimeSpan` - problems acquiring logs after shutdown seem common - nearly double `TimeoutExtensions.DefaultTimeoutValue` - remove `[Repeat]` on `CheckFrebDisconnect(...)` because it makes test _more_ flaky - check more events in `EventLogHelpers` nit: Update a couple of timeout-related comments
ghost
added
the
|
/fyi @HaoK in case you're interested while this is a work in progress. Will likely need to update some |
dougbu
requested review from
Tratcher,
halter73 and
BrennanConroy
as code owners
dougbu
commented
Mar 27, 2022
| [ConditionalFact] | ||
| [Repeat(10)] |
There was a problem hiding this comment.
General note: [Repeat] is useful when testing reliability but just makes things more flaky if checked in for a non-quarantined test.
HaoK
approved these changes
Mar 28, 2022
This was referenced Mar 30, 2022
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClient.TimeoutvaluesTimeoutAfter(...)timeout to 15 minutes (from 10)TestConnection.TimeoutandIISExpressDeployer.ShutdownTimeSpanTimeoutExtensions.DefaultTimeoutValue[Repeat]onCheckFrebDisconnect(...)because it makes test more flakyEventLogHelpersnit: Update a couple of timeout-related comments