Support all return types from handler in filters #41372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support all return types from handler in filters * Address feedback from peer review * Fix up Task and ValueTask handling * ExecuteAwait to ExecuteAwaited * Actually await void-returning Tasks and ValueTasks * Update comment for new logic * Polish and update tests * Tweaks and test fixes * Tweak await of void-returning Task * Fix correct ExecuteTask invocation
captainsafia
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
ghost
added
the
captainsafia
added
old-area-web-frameworks-do-not-use
BrennanConroy
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #41310 to main.